Handle disabled preload config in firefox #7106
Conversation
🦋 Changeset detectedLatest commit: 4aa2878 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
| // `network.preload` config disabled and we'll _never_ get onload/onerror | ||
| // callbacks. Let's try to confirm this with a totally invalid link preload | ||
| // which should immediately throw the onerror | ||
| if (stylesheetPreloadTimeouts >= 3) { |
There was a problem hiding this comment.
Commented on the Firefox bug, but you really want document.createElement("link").relList.supports("preload") or so.
In any case, I wouldn't bother dealing with it unless you want to also deal with browsers that don't support <link rel=preload> (which is fine, but can be simpler as per the above).
This reverts commit a6a0dc2.
I'm not sure we want this, but it's a POC for a potential fix for #2619
This adds some client-side detection of preload timeouts (after 3s) and once 3 stylesheet preloads timeout, we try to force a preload
link.onerror. If that also times out - we deduce that preload is not supported by the browser (or disabled by the user) and we stop trying to inject preloads for stylesheets on client side navigations.Closes #2619